diff --git a/router/scripts/restart-wan b/router/scripts/restart-wan index 4f3385f..f42f518 100644 --- a/router/scripts/restart-wan +++ b/router/scripts/restart-wan @@ -26,10 +26,10 @@ ping_test() { wan_monitor "Running ping test..." while [ $count_tries -lt $MAX_TRIES ]; do - if /bin/ping -c 1 -W $PING_WAIT $@ >/tmp/wan_check.log; then + if /bin/ping -c 1 -W $PING_WAIT $PING_HOST >/tmp/wan_check.log 2>&1; then ping_test_passed=1 wan_monitor "Ping test succeeded within $PING_WAIT secs." - exit 0 + return 0 # Return success else sleep 1 count_tries=$((count_tries + 1)) @@ -37,12 +37,11 @@ ping_test() { fi done - return $ping_test_passed + return 1 # Return failure } - - -if [ $(ping_test $PING_HOST) -gt 0 ]; then +# Main script execution +if ping_test; then wan_monitor "Internet was reachable. No need to restart WAN." else wan_monitor "Pings failed. Internet must be down." @@ -50,3 +49,4 @@ else fi +